Update EntityInstanceId.parse signature #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the EntityInstanceId.parse method signature to reflect that it always returns an EntityInstanceId or throws a ValueError, rather than returning Optional[EntityInstanceId]. The changes update all call sites to use try-except blocks instead of checking for None.
- Changed method signature from
Optional[EntityInstanceId]toEntityInstanceId - Updated three usage sites to catch
ValueErrorinstead of checking for None return - Improved error handling consistency across the SDK
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| durabletask/entities/entity_instance_id.py | Updated parse method return type signature from Optional[EntityInstanceId] to EntityInstanceId |
| durabletask/worker.py | Updated two call sites to use try-except blocks for ValueError instead of checking for None |
| durabletask/entities/entity_metadata.py | Updated from_entity_response method to catch ValueError from parse instead of checking for None |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the signature of EntityInstanceId.parse to reflect that it will always either return or throw. Also updates corresponding usages in the SDK